Php Register Form Wont Inject Into DataBase?

M

Michael C

New member
Here is register.php

<?php
echo "<h1>Register</h1>";

$submit = $_POST['submit'];


//form data
$username = strip_tags($_POST['username']);
$steamid = strip_tags($_POST['steamid']);
$password = strip_tags($_POST['password']);
$cpass = strip_tags($_POST['cpass']);


if ($submit)
{
if ($username&&$password&&cpass&&$steamid)
{
if($password==$cpass)
{
if(strlen($username)>25)
{
echo "Your username must be <b>under</b> 25 characters in length!";
}
else

if (strlen($password)>25||strlen($password)<6)
{
echo "Password mush be between 6 and 25 characters";
}
else
{
//register user
$password = md5($password);
$cpass = md5($cpass);

$connect = mysql_connect("","","");
if (!$connect)
{
die('Could not connect: ' . mysql_error());
}

mysql_select_db("", $connect);


$sql = mysql_query("INSERT INTO users ( `id` , `username` , `password` , `steamid` ) VALUES ( '', '$username', '$password', '$steamid')");
if (!mysql_query($sql,$connect))
{
die('Error: ' . mysql_error());
}
else
echo "You've Been Registered! Welcome, ",$username, ". <a href='index.html'>Return</a> to login page";

}

}
else
echo "Your passwords do not match!";


}
else
echo "Please fill in <b>ALL</b> fields!";
}

?>

<html>

<form action='register.php', method='POST'>
<table>
<tr>
<td>
Desired Username:
</td>
<td>
<input type='text' name='username'>
</td>
</tr>
<tr>
<td>
Exact SteamID:
</td>
<td>
<input type='text' name='steamid'>
</td>
</tr>
<tr>
<td>
Password:
</td>
<td>
<input type='password' name='password'>
</td>
</tr>
<tr>
<td>
Comfirm Password:
</td>
<td>
<input type='password' name='cpass'>
</td>
</tr>
</table>
<p>
<input type='submit' name='submit' value='Register'>


</html>



Now when i click register it says it works but i look at the database and theres no new user...

And i know i am connected right i get no errors for that at all..(Connections are left blank on purpose)

So what am i doing wrong??
When i add this

if (!mysql_query($sql,$connect))
{
die('Error: ' . mysql_error());
}
i get something saying nothing in query???


i get something saying no
And <?=$_SERVER['PHP_SELF']?>

Didnt work :/
 
Back
Top