PHP/Javascript newbie - alert box problem?

  • Thread starter Thread starter H
  • Start date Start date
H

H

Guest
Hi, i have made a script, which should pop up an error if a field is left blank. The error does pop up, but it still redirects the user to the next page, which I dont want it to do.



here is the javascript code part:


<script language="javascript" type="text/javascript">
function CheckFields() {
var tempvar = false;
if (surname.value.length < "1") {
var tempvar = true;
}
if (first_name.value.length < "1") {
var tempvar = true;
}
if (email.value.length < "1") {
var tempvar = true;
}
if (year.value.length < "1") {
var tempvar = true;
}
if (password.value.length < "1") {
var tempvar = true;
}
if (tempvar == false) { return true; }
else {alert("Please enter all the information required."); return
false; }
}

</script>



here is the PHP part:


<?php

echo
"<form name=\"update\"action=\"update.php\" method=\"post\" onSubmit=\"return CheckFields()\">

<p>MemberID: <input type=\"text\" readonly=\"readonly\" name=\"memberid\" id=\"memberid\" value=\"$memberid\" size=\"1\" /></p>

<p>Surname: <input type=\"text\" name=\"surname\" id=\"surname\" value=\"$surname\" size=\"20\" /></p>

<p>First Name: <input type=\"text\" name=\"first_name\" value=\"$firstname\" id=\"first_name\" size=\"20\" /></p>

<p>Email: <input type=\"text\" name=\"email\" value=\"$email\" id=\"email\" size=\"3\" /></p>

<p>Date Of Birth:

<select name=\"day\">
<option value=\"$day\">$day</option>
<option value=\"01\">01</option>
<option value=\"02\">02</option>
<option value=\"03\">03</option>
<option value=\"04\">04</option>
<option value=\"05\">05</option>
<option value=\"06\">06</option>
<option value=\"07\">07</option>
<option value=\"08\">08</option>
<option value=\"09\">09</option>
<option value=\"10\">10</option>
<option value=\"11\">11</option>
<option value=\"12\">12</option>
<option value=\"13\">13</option>
<option value=\"14\">14</option>
<option value=\"15\">15</option>
<option value=\"16\">16</option>
<option value=\"17\">17</option>
<option value=\"18\">18</option>
<option value=\"19\">19</option>
<option value=\"20\">20</option>
<option value=\"21\">21</option>
<option value=\"22\">22</option>
<option value=\"23\">23</option>
<option value=\"24\">24</option>
<option value=\"25\">25</option>
<option value=\"26\">26</option>
<option value=\"27\">27</option>
<option value=\"28\">28</option>
<option value=\"29\">29</option>
<option value=\"30\">30</option>
<option value=\"31\">31</option>
</select>

<select name=\"month\">
<option value=\"$month\">$month</option>
<option value=\"01\">January</option>
<option value=\"02\">February</option>
<option value=\"03\">March</option>
<option value=\"04\">April</option>
<option value=\"05\">May</option>
<option value=\"06\">June</option>
<option value=\"07\">July</option>
<option value=\"08\">August</option>
<option value=\"09\">September</option>
<option value=\"10\">October</option>
<option value=\"11\">November</option>
<option value=\"12\">December</option>
</select>

<input type=\"text\" name=\"year\" value=\"$year\" id=\"year\" size=\"4\" /></p>

<p>Current Password: <input type=\"password\" id=\"password\"name=\"password\" size=\"20\" /></p>

<input type=\"submit\" value=\"Update Details\"/>
</form>";

?>

Sorry for the long code.

Anyone know whats wrong?

Thanks
 
Back
Top