Having used both my iPhone and the Xperia X10, I'd go for the iPhone.
The X10 is classic Sony Ericsson: good hardware, bad software. It's fast, it has a large screen and it comes with a solid camera, but most of the custom software isn't well-executed. Timescape and Mediascape are fairly...