what is wrong with this php/html code?

T

Tyler

New member
?>
<html>
<head>
<title>Bad Calculator</title>
<style>
.error{ color: red; }
input{ border: 1px solid black; }
</style>
</head>
<body>
<h1>Bad Calculator</h1>
<p>This is a bad calculator.. please find my errors.</p>
<?php
$firstNumber = 0;
$dosNombre = 0;
$answer = 0;
if (isset($_POST['calculateButton'])) {
if (isset($_POST['firstNumber'])and !empty($_POST['firstNumber'])) {
$firstNumber = $_POST['firstNumber']
} else {
echo "<span class='error'>YOU DIDN'T ENTER THE FIRST NUMBER!</span><br />";
}
if (isset($_POST['secondNumber']) and !empty($_POST['secondNumber'])) {
$secondNumber = $_POST['secondNumber'];
} else {
echo "<span class='error'>YOU DIDN'T ENTER THE SECOND NUMBER!</span><br />";
}
if (!empty($firstNumber) and !empty($secondNumber)) {
if ($_POST['operator'] == 'add') {
$answer = $firstNumber + $firstNumber;
} else if ($_POST['subtract'] == 'sub') {
$answer = $firstNumber - $firstNumber;
} else if ($_POST['multiply'] == 'mul') {
$answer = $firstNumber * $firstNumber;
} else if ($_POST['divide'] == 'div') {
$answer = $firstNumber / $firstNumber;
} else {
echo "<span class='error'>No operator? That's confusing</span><br />";
} else {
echo "<span class='error'>It would be impossible to ever get here.. an if statement can't have two elses.. I should remove this part.</span><br />";
}
}
}

echo <<<CALC_FORM
<form action="calc.php" method="GET">
<input type="textbox" name="firstNumber" value="$firstNumber" /><br />
<input type="radio" name="operator" value="add" CHECKED> +
<input type="radio" name="operator" value="sub"> -<br />
<input type="radio" name="operator" value="add"> *
<input type="radio" name="operator" value="div"> /<br />
<input type="textbox" name="secondNumber" value="$secondNumber" /><br />
<input type="submit" name="calculate" value="Calculate!" /><br />
</form>
Answer:
<input type="textbox" value="$answer" DISABLED/><br />
CALC_FORM;


?>

</body>
</html>
 
Back
Top