I don't belive that they're considered "lucky", just a symbol of wealth and prosperity.
The "gold" color variation of carp was very rare when first discovered, and the Chinese Royalty kept them away from the public, as yellow was the imperial color, and normal people weren't "good enough" to...